Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_6_X] ParticleFlow HB customisation for 2023 TSG studies #40689

Merged
merged 1 commit into from
Feb 8, 2023
Merged

[12_6_X] ParticleFlow HB customisation for 2023 TSG studies #40689

merged 1 commit into from
Feb 8, 2023

Conversation

abdoulline
Copy link

@abdoulline abdoulline commented Feb 3, 2023 •
edited
Loading

PR description:

Snippet for cmsDriver (step3) customisation for 2023 TSG studies
HB "mild"(medium) cuts suggested in Slide#12
https://indico.cern.ch/event/1237252/contributions/5204534/attachments/2574097/4448011/v4_Prep_for_2023_TSG_Jan17_2023.pdf

Without this snippet, one would need to include in the cmsDriver command
a bulky list of 7 very long commands (with the values explicitly specified in all the cases):
--customise_commands "..."

So, even though this is not a must/indispensable PR, just rather an "opportunistic" one, but if 12_6_X patch is planned in the near future, inclusion of this PR would make cmsDriver command much more compact/readable:
--customise RecoParticleFlow/PFClusterProducer/particleFlow_HB2023.customiseHB2023

PR validation:

Checked (via edmConfigDump) that it brings necessary modifications with step3 cmsDriver customisation.

If this PR is a backport

It's not really a backport, rather a provisional 12_6_X-only snippet specifically for 2023 TSG studies

@cmsbuild cmsbuild added this to the CMSSW_12_6_X milestone Feb 3, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

A new Pull Request was created by @abdoulline (Salavat Abdullin) for CMSSW_12_6_X.

It involves the following packages:

  • RecoParticleFlow/PFClusterProducer (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @rovere, @lgray, @missirol, @hatakeyamak, @ebrondol, @sameasy, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@abdoulline abdoulline changed the title [12_6_X] ParticleFlow HB 2023 customisation [12_6_X] ParticleFlow HB customisation for 2023 TSG studies Feb 3, 2023
@perrotta
Copy link
Contributor

perrotta commented Feb 3, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de081b/30394/summary.html
COMMIT: 296d389
CMSSW: CMSSW_12_6_X_2023-02-03-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40689/30394/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

  • 11846.011846.0_ZEE_14+2021PU+ZEE_14TeV_TuneCP5_GenSimINPUT+DigiPU+RecoNanoPU+HARVESTNanoPU/step2_ZEE_14+2021PU+ZEE_14TeV_TuneCP5_GenSimINPUT+DigiPU+RecoNanoPU+HARVESTNanoPU.log

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3458651
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3458629
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

please test
Let's fix the input error

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de081b/30466/summary.html
COMMIT: 296d389
CMSSW: CMSSW_12_6_X_2023-02-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40689/30466/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460357
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460332
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1
Just a shortcut for some laborious driver commands. Not sure it will be useful at this point, but shouldn't hurt.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 8, 2023

+1

@cmsbuild cmsbuild merged commit 545045b into cms-sw:CMSSW_12_6_X Feb 8, 2023
@swagata87 swagata87 mentioned this pull request Feb 13, 2023
Merged
@swagata87 swagata87 mentioned this pull request Apr 4, 2023
Merged
@abdoulline abdoulline deleted the PFCluster_HB2023 branch April 18, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_6_X
Development

Successfully merging this pull request may close these issues.
4 participants
@abdoulline @cmsbuild @perrotta @mandrenguyen